Skip to content

Change role check from > 1 to >= 1#160

Closed
0xEmma wants to merge 1 commit intohackthebox:mainfrom
0xEmma:patch-9
Closed

Change role check from > 1 to >= 1#160
0xEmma wants to merge 1 commit intohackthebox:mainfrom
0xEmma:patch-9

Conversation

@0xEmma
Copy link
Copy Markdown
Collaborator

@0xEmma 0xEmma commented Oct 18, 2025

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

Describe your changes here and explain why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Add any other context or screenshots here.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.77%. Comparing base (f092737) to head (40e3ad0).
⚠️ Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
src/cmds/core/user.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   53.66%   55.77%   +2.11%     
==========================================
  Files          44       50       +6     
  Lines        2486     2885     +399     
==========================================
+ Hits         1334     1609     +275     
- Misses       1152     1276     +124

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xEmma 0xEmma closed this Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimoschi dimoschi Awaiting requested review from dimoschi dimoschi is a code owner

@makelarisjr makelarisjr Awaiting requested review from makelarisjr makelarisjr is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@0xEmma